Skip to content

Disconnect extension bridge on logout #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2025
Merged

Disconnect extension bridge on logout #7563

merged 3 commits into from
Sep 1, 2025

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Aug 31, 2025 •
edited by ellipsis-dev bot
Loading

Important

Update authStateChangedHandler to disconnect BridgeOrchestrator on logout and improve error handling in connectOrDisconnect.

  • Behavior:
    • authStateChangedHandler in extension.ts updated to disconnect BridgeOrchestrator on user logout by calling connectOrDisconnect with null and false.
    • Logs success or failure of disconnection to cloudLogger.
  • Error Handling:
    • In BridgeOrchestrator.ts, connectOrDisconnect logs an error if options are missing when attempting to connect.

This description was created by Ellipsis for 1f8be2b. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners August 31, 2025 04:10
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 31, 2025
roomote[bot]
roomote bot reviewed Aug 31, 2025
View reviewed changes
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several issues that need attention. The implementation correctly adds logout handling for the BridgeOrchestrator, but there are some concerns with test file naming conventions and test isolation that should be addressed.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 31, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 31, 2025
@mrubens mrubens merged commit c970274 into main Sep 1, 2025
14 of 18 checks passed
@mrubens mrubens deleted the disconnect_bridge_on_logout branch September 1, 2025 12:50
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 1, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roomote roomote[bot] roomote[bot] left review comments

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrubens @hannesrudolph